fix: order remote browser close events#3099
Open
rohan-patnaik wants to merge 2 commits into
Open
Conversation
Skn0tt
approved these changes
Jun 9, 2026
Member
|
Looks like tests are red. |
Contributor
Author
|
Let me check and come back |
Contributor
Author
|
Pushed a follow-up fix after checking the Windows CI timeouts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disconnectedon the next event-loop turn.wait_for_eventrejection beforebrowser.close()returns and beforedisconnectedfires.Closes #3097
Tests
python -m py_compile playwright\_impl\_browser_type.py tests\async\test_browsertype_connect.pyFull browser tests were not run locally because this checkout does not contain the generated Playwright driver payload.